-
Notifications
You must be signed in to change notification settings - Fork 407
Adding net10.0 to the list of target frameworks #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
lipchev
commented
Dec 7, 2025
- Adding net10.0 to the list of target frameworks
- updating all packages to their latest versions
- updating all packages to their latest versions
| # TODO check if the extension for VS2022 is compatible it VS2026 | ||
| if($vsInstance.Contains('2026') -or $vsInstance.Contains('2022')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, the local build doesn't throw any errors (when running the script as administrator) but I haven't tested if the resulting code is any different (normally it shouldn't, as we haven't changed anything about the nano-project itself).
| <!-- Disable ILLink analyzers due to incompatibility with C# 14 extension members preview | ||
| "CSC : error AD0001: Analyzer 'ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.NonErrorNamedTypeSymbol' to type 'Microsoft.CodeAnalysis.IMethodSymbol'.'." --> | ||
| <IsAotCompatible>false</IsAotCompatible> | ||
| <!-- <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible> --> | ||
| <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net10.0'))">true</IsAotCompatible> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that the persistence of this ILink.RoslyAnalyzer exception is likely related to this issue: dotnet/runtime#120728. That's a bit of a bummer, as if we wanted to use the extension features in any of the other projects (not just the extension properties) we'd be forced to push the AoT compatibility version to net10.0
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |